Re: [PATCH v7 6/6] arm64: dts: qcom: x1e80100-crd: Define RGB sensor for cci1_i2c1

From: Bryan O'Donoghue
Date: Fri Apr 25 2025 - 17:06:52 EST


On 25/04/2025 22:01, Konrad Dybcio wrote:
+ orientation = <0>; /* front facing */
This most definitely needs a dt binding definition instead of a comment

That's standard somewhere.

But now that you mention it, it should be a define not an integer.

---
bod