Re: [PATCH 2/3] arm64: dts: qcom: Add support for X1E80100 Dell Inspirion 14 Plus 7441

[Konrad Dybcio]

On 4/24/25 1:53 AM, Bryan O'Donoghue wrote:
> Add support for Dell Inspiron 14p 7441.
> 
> Working:
> - WiFi
> - Bluetooth
> - USB Type-C x 2
> - USB Type-A
> - USB Finger Print reader
> - Display
> - NVME
> - Keyboard
> - Touchpad
> 
> WIP not included:
> - Audio
> - Camera
> - Embedded Controller
> - Battery
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---

[...]

> +		pinctrl-names = "default";
> +		pinctrl-0 = <&cam_indicator_en>;

property-n
property-names

file-wide, please

[...]

> +	/*
> +	 * TODO: These two regulators are actually part of the removable M.2
> +	 * card and not the CRD mainboard. Need to describe this differently.
> +	 * Functionally it works correctly, because all we need to do is to
> +	 * turn on the actual 3.3V supply above.
> +	 */

Well there's definitely no CRD mainboard in there.. not quite, anyway

[...]

> +&i2c5 {
> +	clock-frequency = <400000>;
> +
> +	status = "okay";
> +
> +	/* Type A Port1 */

But there only seems to be one?

[...]

> +	/* FRP eUSB */

Factory Reset Protection?

Please spell out Fingerprint scanner if that's what that is

[...]

> +&i2c20 {
> +	/* GPIO_80, GPIO_81 */

That can be tracked down by looking up the node definition, it
would be however good to know what sits on this bus and at what
addresses

[...]

> +	cam_rgb_default: cam-rgb-default-state {
> +		mclk-pins {
> +			/* cam_aon_mclk4 */

I don't think this comment adds much

[...]

> +&usb_mp_dwc3 {
> +	phys = <&usb_mp_hsphy0>, <&usb_mp_qmpphy0>;
> +	phy-names = "usb2-0", "usb3-0";

Any reason to limit these?

looks nice otherwise

Konrad