Re: [PATCH] iio: adc: ad7173: fix compiling without gpiolib

[Andy Shevchenko]

On Fri, Apr 25, 2025 at 7:55 PM David Lechner <dlechner@xxxxxxxxxxxx> wrote:
> On 4/22/25 4:03 PM, Andy Shevchenko wrote:
> > On Tue, Apr 22, 2025 at 11:12 PM David Lechner <dlechner@xxxxxxxxxxxx> wrote:

> >> Fix compiling the ad7173 driver when CONFIG_GPIOLIB is not set by
> >> selecting GPIOLIB to be always enabled and remove the #if.
> >
> > I'm not sure we need to select GPIOLIB. If you want it, depend on it.
> > GPIOLIB is not a hidden symbol, so why "select"?
> >
> Since this parts of the driver unrelated to GPIO provider/consumer rely on this
> being enabled to function, select seems more appropriate.

Hmm... The current state of affairs is 177 for select vs. 231 for
depends on. I dunno how many of them are historical, for now it seems
like 40%/60%. So if you think so, go for it!


-- 
With Best Regards,
Andy Shevchenko