Re: [PATCH v2 2/2] media: qcom: camss: x1e80100: Fixup x1e csiphy supply names

[Dmitry Baryshkov]

On Fri, Apr 25, 2025 at 04:17:34PM +0100, Bryan O'Donoghue wrote:
> Amend the names of the csiphy supplies to be specific to each CSIPHY thus
> allowing for the case where PHYs have individual or shared rails.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
>  drivers/media/platform/qcom/camss/camss.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 06f42875702f02f9d8d83d06ddaa972eacb593f8..d63bc7dc951690132e07ee0fb8df7cef9b66927d 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -2486,8 +2486,8 @@ static const struct resources_icc icc_res_sm8550[] = {
>  static const struct camss_subdev_resources csiphy_res_x1e80100[] = {
>  	/* CSIPHY0 */
>  	{
> -		.regulators = { "vdd-csiphy-0p8-supply",
> -				"vdd-csiphy-1p2-supply" },
> +		.regulators = { "vdd-csiphy0-0p8",
> +				"vdd-csiphy0-1p2" },

This is an ABI break. Please mention in the cover message why we are
allowing it.

>  		.clock = { "csiphy0", "csiphy0_timer" },
>  		.clock_rate = { { 300000000, 400000000, 480000000 },
>  				{ 266666667, 400000000 } },

-- 
With best wishes
Dmitry