Re: [PATCH 2/2] arm64: dts: allwinner: h6: Add OrangePi 3 LTS DTS

[Andrew Lunn]

> > +&emac {
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&ext_rgmii_pins>;
> > +	phy-mode = "rgmii-rxid";
> 
> So relating to what Andrew said earlier today, should this read rgmii-id
> instead? Since the strap resistors just set some boot-up value, but we
> want the PHY driver to enable both RX and TX delay programmatically?

Yes.

There is a checkpatch.pl patch working its way through the system
which will add warning about any rgmii value other than rgmii-id. Such
values need a comment that the PCB has extra long clock
lines. Hopefully that will make people actually stop and think about
this, rather than just copy broken vendor code.

	Andrew