Re: cgroup null pointer dereference

From: Waiman Long
Date: Fri Apr 25 2025 - 11:23:19 EST



On 4/25/25 11:11 AM, hch wrote:
On Fri, Apr 25, 2025 at 11:04:58AM -0400, Waiman Long wrote:
On 4/25/25 10:54 AM, hch wrote:
On Fri, Apr 25, 2025 at 02:22:31AM +0000, Kamaljit Singh wrote:
It should also be in v6.15-rc1 branch but is missing in the nvme branch
that you are using. So you need to use a more updated nvme, when
available, to avoid this problem.

Thank you for finding that commit. I'll look for it.

Christoph, Sagi, Keith, Others,
Can this commit be merged into the nvme-6.15 branch please?
What commit?

commit 7d6c63c31914 ("cgroup: rstat: call cgroup_rstat_updated_list with
cgroup_rstat_lock")
I don't see how that is relevant for the nvme tree?

The nvme-6.15-2025-04-10 branch used by Kmaljit includes some v6.15
commits like the cgroup commit 093c8812de2d3 ("cgroup: rstat:
Cleanup flushing functions and locking") but not its fix commit
7d6c63c31914 ("cgroup: rstat: call cgroup_rstat_updated_list with
cgroup_rstat_lock"). That can cause system crash in some cases. That
problem will be resolved if nvme is rebased on top of v6.15-rc1 or
later as the fix commit will be included.

Cheers,
Longman