Re: [PATCH] drm/panel: samsung-atna33xc20: extend msleep in atana33xc20_disable to avoid glitch

[Ilpo Järvinen]

On Fri, 25 Apr 2025, Alvin1 Chen wrote:

> samsung-atna40ct03 encouters glitch when powering off, extend msleep

encounters

msleep()

I'd also suggest you describe the glitch a bit more than that.

> in atana33xc20_disable to 40 can avoid this symptom.
> 
> Change-Id: I4d052621d3c3e0fdae0ac472fe5da151f46be237
> Signed-off-by: Alvin1 Chen <alvin1.chen@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/panel/panel-samsung-atna33xc20.c | 4 ++--

Please use scripts/get_maintainer.pl to send this v2 of this patch to 
correct lists and people. Thanks.

-- 
 i.

>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c
> index 9a482a744b8c..87a4e1c47aaa 100644
> --- a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c
> +++ b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c
> @@ -154,10 +154,10 @@ static int atana33xc20_disable(struct drm_panel *panel)
>  	p->el3_was_on = true;
>  
>  	/*
> -	 * Sleeping 20 ms here (after setting the GPIO) avoids a glitch when
> +	 * Sleeping 40 ms here (after setting the GPIO) avoids a glitch when
>  	 * powering off.
>  	 */
> -	msleep(20);
> +	msleep(40);
>  
>  	return 0;
>  }
>