Re: [PATCH 1/2] drm/v3d: fix client obtained from axi_ids on V3D 4.1

[Chema Casanova]

El 10/4/25 a las 14:31, Maíra Canal escribió:
> Hi Chema,
>
> On 09/04/25 12:55, Jose Maria Casanova Crespo wrote:
> > The client that causes an MMU error is expected to be reported.
> > But in the case of MMU TFU errors, a non existing client
>
> "In the case of MMU errors caused by the TFU unit, [...]"

Message updated.

> > was being reported. This happened because because the client
>
> There are two "because" in the sentence. Could you add an example of the
> a MMU error with a non-existing client in the commit message?
Example added.

[...]
> >           }
> >             dev_err(v3d->drm.dev, "MMU error from client %s (%d) at 
> > 0x%llx%s%s%s\n",
>
> As we are declaring `begin` and `end` as hexadecimal numbers in the
> code, could we display AXI ID as a hexadecimal as well? Just to ease
> future debugging. You would need to change "(%d)".
Change done.
> Please, don't forget to mention this change in the commit message of v2.
Already included in v2.

Thanks for your review Maíra.

Kind regards.
Chema Casanova