Re: [PATCH v2 2/2] serdev: Remove repeated device name in dev_(err|dbg) messages

[Zijun Hu]

On 2025/4/25 13:38, Jiri Slaby wrote:
>>
>> diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
>> index
>> 971651b8e18dcbb5b7983cdfa19e7d60d4cd292b..f00106de76a0f1e547310c7d21cc2fe3d5869e28 100644
>> --- a/drivers/tty/serdev/core.c
>> +++ b/drivers/tty/serdev/core.c
>> @@ -118,12 +118,12 @@ int serdev_device_add(struct serdev_device *serdev)
>>         err = device_add(&serdev->dev);
>>       if (err < 0) {
>> -        dev_err(&serdev->dev, "Can't add %s, status %pe\n",
>> -            dev_name(&serdev->dev), ERR_PTR(err));
>> +        dev_err(&serdev->dev, "Can't add serdev, status %pe\n",
>> +            ERR_PTR(err));
> 
> You don't need to wrap now.
> 
> Could you also get rid of ERR_PTR() and print err directly using %d?
> 
>>           goto err_clear_serdev; 

sure, will do it in next revision.