Re: [PATCH v2 2/2] PCI: Remove redundant MPS configuration

From: Hans Zhang
Date: Fri Apr 25 2025 - 06:28:05 EST




On 2025/4/25 18:17, Niklas Cassel wrote:
On Fri, Apr 25, 2025 at 05:57:08PM +0800, Hans Zhang wrote:
With the PCI core now centrally configuring root port MPS to
hardware-supported maximums (via 128 << pcie_mpss) during host probing,
platform-specific MPS adjustments are redundant. This patch removes the
custom the configuration of the max payload logic to align with the
standardized initialization flow.

By eliminating redundant code, this change prevents conflicts with global
PCIe hierarchy tuning policies and reduces maintenance overhead. The Meson
driver now fully relies on the core PCI framework for MPS configuration,
ensuring consistency across the PCIe topology while preserving
hardware-specific MRRS handling.

Signed-off-by: Hans Zhang <18255117159@xxxxxxx>
---
drivers/pci/controller/dwc/pci-meson.c | 17 -----------------
drivers/pci/controller/pci-aardvark.c | 2 --

Since you are touching two drivers (and the changes are not exactly identical),
I suggest that you do one patch per driver.

Dear Niklas,

Thank you very much for your reply. In the next version, I will split two patches.

Best regards,
Hans