Re: [PATCH v2 2/9] dt-bindings: serial: describe SA8255p
From: Krzysztof Kozlowski
Date: Fri Apr 25 2025 - 06:13:55 EST
On Fri, Apr 18, 2025 at 08:42:28PM GMT, Praveen Talari wrote:
> + interrupts:
> + minItems: 1
> + items:
> + - description: UART core irq
> + - description: Wakeup irq (RX GPIO)
> +
> + interrupt-names:
> + description:
> + The UART interrupt and optionally the RX in-band wakeup interrupt.
Drop description. It is not even accurate because you do not allow
wakeup to be optional.
> + items:
> + - const: uart
> + - const: wakeup
> +
> + power-domains:
> + minItems: 2
> + maxItems: 2
> +
> + power-domain-names:
> + items:
> + - const: power
> + - const: perf
> +
> +required:
> + - compatible
> + - interrupts
> + - reg
Keep the same order as in properties. You already got comment about
placement of 'reg'.
Best regards,
Krzysztof