RE: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

[Chang, Junxiao]

On Fri, 25 Apr 2025, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote:
>On Fri, 25 Apr 2025, Junxiao Chang <junxiao.chang@xxxxxxxxx> wrote:
>> MEI GSC interrupt comes from i915. It has top half and bottom half.
>>
>> -	ret = generic_handle_irq(gt->gsc.intf[intf_id].irq);
>> +	/* It can be called in both irq context and in thread context */
>
>What is "It" in this case?
"It" means GSC interrupt handler, which is called via below API generic_handle_irq_safe. Sebastain has a comment on it as well that it doesn't deserves a comment. I could delete this comment.
>
>> +	ret = generic_handle_irq_safe(gt->gsc.intf[intf_id].irq);
>> +
>>  	if (ret)
>>  		gt_err_ratelimited(gt, "error handling GSC irq: %d\n", ret);  }
>
>--
>Jani Nikula, Intel