RE: [PATCH] ufs: core: Remove redundant query_complete trace

[Avri Altman]

> The query_complete trace was not removed after ufshcd_issue_dev_cmd()
> was called from the bsg path, resulting in duplicate output.
> 
> Below is an example of the trace:
> 
>  ufs-utils-773     [000] .....   218.176933: ufshcd_upiu: query_send:
> 0000:00:04.0: HDR:16 00 00 1f 00 01 00 00 00 00 00 00, OSF:03 07 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00
>  ufs-utils-773     [000] .....   218.177145: ufshcd_upiu: query_complete:
> 0000:00:04.0: HDR:36 00 00 1f 00 01 00 00 00 00 00 00, OSF:03 07 00 00 00
> 00 00 00 00 00 00 08 00 00 00 00
>  ufs-utils-773     [000] .....   218.177146: ufshcd_upiu: query_complete:
> 0000:00:04.0: HDR:36 00 00 1f 00 01 00 00 00 00 00 00, OSF:03 07 00 00 00
> 00 00 00 00 00 00 08 00 00 00 00
> 
> This commit removes the redundant trace call in the bsg path, preventing
> duplication.
> 

Fixes: 71aabb747d5f ("scsi: ufs: core: Reuse exec_dev_cmd")
> Signed-off-by: Keoseong Park <keosung.park@xxxxxxxxxxx>
Reviewed-by: Avri Altman <avri.altman@xxxxxxxxxxx>

> ---
>  drivers/ufs/core/ufshcd.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index be65fc4b5ccd..c78c7ad4e393 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -7271,8 +7271,6 @@ static int ufshcd_issue_devman_upiu_cmd(struct
> ufs_hba *hba,
>  			err = -EINVAL;
>  		}
>  	}
> -	ufshcd_add_query_upiu_trace(hba, err ? UFS_QUERY_ERR :
> UFS_QUERY_COMP,
> -				    (struct utp_upiu_req *)lrbp->ucd_rsp_ptr);
> 
>  	return err;
>  }
> --
> 2.25.1
>