Re: [PATCH V2 1/3] Sched: Scheduler time slice extension

From: K Prateek Nayak
Date: Thu Apr 24 2025 - 23:49:06 EST


Hello Prakash,

On 4/25/2025 6:49 AM, Prakash Sangappa wrote:
static void hrtick_clear(struct rq *rq)
{
+ rseq_delay_resched_tick();
This is called from __schedule(). If you set the need-resched flag here,
it gets removed shortly after. Do I miss something?
hrtick_clear() is also called when the cpu is being removed in sched_cpu_dying().
We need to set resched there?

sched_cpu_dying() is called from the cpuhp thread which will go away
once the hotplug is done and shouldn't need this. Furthermore, cpuhp
thread will not use the "rseq_sched_delay" API so removing this should
be fine.

--
Thanks and Regards,
Prateek