RE: [PATCH v4 2/5] dt-bindings: pci: cadence: Extend compatible for new EP configurations

[Manikandan Karunakaran Pillai]

>
>
>On Thu, Apr 24, 2025 at 04:29:35PM +0100, Conor Dooley wrote:
>> On Thu, Apr 24, 2025 at 09:04:41AM +0800, hans.zhang@xxxxxxxxxxx wrote:
>> > From: Manikandan K Pillai <mpillai@xxxxxxxxxxx>
>> >
>> > Document the compatible property for HPA (High Performance
>Architecture)
>> > PCIe controller EP configuration.
>>
>> Please explain what makes the new architecture sufficiently different
>> from the existing one such that a fallback compatible does not work.
>>
>> Same applies to the other binding patch.
>
>Additionally, since this IP is likely in use on your sky1 SoC, why is a
>soc-specific compatible for your integration not needed?
>

The sky1 SoC support patches will be developed and submitted by the Sky1 team separately.

>>
>> Thanks,
>> Conor.
>>
>> >
>> > Signed-off-by: Manikandan K Pillai <mpillai@xxxxxxxxxxx>
>> > Signed-off-by: Hans Zhang <hans.zhang@xxxxxxxxxxx>
>> > ---
>> >  .../devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml          | 6 ++++--
>> >  1 file changed, 4 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
>b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
>> > index 98651ab22103..a7e404e4f690 100644
>> > --- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
>> > +++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
>> > @@ -7,14 +7,16 @@ $schema: http://devicetree.org/meta-
>schemas/core.yaml#
>> >  title: Cadence PCIe EP Controller
>> >
>> >  maintainers:
>> > -  - Tom Joseph <tjoseph@xxxxxxxxxxx>
>> > +  - Manikandan K Pillai <mpillai@xxxxxxxxxxx>
>> >
>> >  allOf:
>> >    - $ref: cdns-pcie-ep.yaml#
>> >
>> >  properties:
>> >    compatible:
>> > -    const: cdns,cdns-pcie-ep
>> > +    enum:
>> > +      - cdns,cdns-pcie-ep
>> > +      - cdns,cdns-pcie-hpa-ep
>> >
>> >    reg:
>> >      maxItems: 2
>> > --
>> > 2.47.1
>> >
>