Re: [PATCH] ocfs2: fix deadlock in ocfs2_get_system_file_inode

From: Al Viro
Date: Thu Apr 24 2025 - 15:46:52 EST


On Thu, Apr 24, 2025 at 09:59:11PM +0530, Kevin Paul Reddy Janagari wrote:
> This issue can be resolved by making the down_read -> down_read_try
> in the ocfs2_read_virt_blocks.

ITYM "can be papered over by..."; *IF* fill_super() is the only place where
these are taken in such order, this is strictly worse than the current
situation - you are taking a false positive from lockdep (fill_super is
not going to have any other threads accessing the same fs instance) and
adding random failures and syslog spew where none existed.

NAK in that form; it _may_ serve as a stopgap if fill_super is not
the only place where we do it in such order, but even then we need
to deal with the problem properly.