Re: [PATCH] mm: workingset: Simplify lockdep check in update_node

From: Johannes Weiner
Date: Thu Apr 24 2025 - 15:17:38 EST


On Mon, Apr 21, 2025 at 06:16:28PM +0100, Pedro Falcato wrote:
> container_of(node->array, ..., i_pages) just to access i_pages again
> is an incredibly roundabout way of accessing node->array itself.
> Simplify it.

Agreed. The other side is shadow_lru_isolate() which goes also goes
through mapping->i_pages. That's probably how it came to be. But your
patch doesn't make that relationship any harder to understand.

> Signed-off-by: Pedro Falcato <pfalcato@xxxxxxx>

Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>

Thanks