Re: [PATCH v8 18/21] x86,fs/resctrl: Remove duplicated trace header files

From: James Morse
Date: Thu Apr 24 2025 - 13:11:43 EST


Hi Fenghua,

On 22/04/2025 15:23, Fenghua Yu wrote:
> On 4/11/25 09:42, James Morse wrote:
>> The copy-pasting python script harmlessly creates some empty trace
>> point header files. Remove them.

>> diff --git a/fs/resctrl/pseudo_lock_trace.h b/fs/resctrl/pseudo_lock_trace.h
>> deleted file mode 100644
>> index 7a6a1983953a..000000000000
>> --- a/fs/resctrl/pseudo_lock_trace.h
>> +++ /dev/null
>> @@ -1,17 +0,0 @@
>> -/* SPDX-License-Identifier: GPL-2.0 */
>> -#undef TRACE_SYSTEM
>> -#define TRACE_SYSTEM resctrl
>> -
>> -#if !defined(_X86_RESCTRL_PSEUDO_LOCK_TRACE_H) || defined(TRACE_HEADER_MULTI_READ)
>> -#define _X86_RESCTRL_PSEUDO_LOCK_TRACE_H
>> -
>> -#include <linux/tracepoint.h>
>> -
>> -#endif /* _X86_RESCTRL_PSEUDO_LOCK_TRACE_H */
>> -
>> -#undef TRACE_INCLUDE_PATH
>> -#define TRACE_INCLUDE_PATH .
>> -
>> -#define TRACE_INCLUDE_FILE pseudo_lock_trace
>> -
>> -#include <trace/define_trace.h>

> Will patches 18-21 be merged into patch 17 eventually before they are pushed into upstream?

Up to the maintainers - but that is the plan I describe in the cover letter.
The history of those patches isn't interesting - but they do need to be broken out to be
reviewed.


Thanks,

James