Re: [PATCH v5 3/5] dt-bindings: wireless: bcm4329-fmac: Use wireless-controller.yaml schema

From: Krzysztof Kozlowski
Date: Thu Apr 24 2025 - 11:38:04 EST


On 24/04/2025 14:09, Johannes Berg wrote:
> On Thu, 2025-04-24 at 10:28 +0200, Krzysztof Kozlowski wrote:
>> On 24/04/2025 10:20, Krzysztof Kozlowski wrote:
>>> On 24/03/2025 18:41, David Heidelberg via B4 Relay wrote:
>>>> From: Janne Grunau <j@xxxxxxxxxx>
>>>>
>>>> The wireless-controller schema specifies local-mac-address as
>>>> used in the bcm4329-fmac device nodes of Apple silicon devices
>>>> (arch/arm64/boot/dts/apple).
>>>>
>>>> Fixes `make dtbs_check` for those devices.
>>>>
>>>> Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
>>>> Signed-off-by: Janne Grunau <j@xxxxxxxxxx>
>>>> Signed-off-by: David Heidelberg <david@xxxxxxx>
>>>
>>> This introduced several new dtbs_check warnings. Including on platforms
>>> which were warnings free. It is nice to fix these warnings when you make
>>> such changes.
>
> Heh, especially since it said it should _fix_ things there.
>
>> I will send the patches for them, except for Apple SoCs.
>
> Thanks, I guess I'll hold the pull request for that. And I guess the
> Apple ones are on David then.
I think you can go ahead. I already referenced that commit from next in
my patches, so I hope that SHA will not change (don't rebase your tree):

https://lore.kernel.org/linux-devicetree/?q=f%3Akrzysztof+%22Align+wifi+node+name+with+bindings%22

Best regards,
Krzysztof