Re: [PATCH iwl-next 06/16] libeth: xdp: add XDPSQ locking helpers

From: Maciej Fijalkowski
Date: Thu Apr 24 2025 - 11:27:55 EST


On Tue, Apr 15, 2025 at 07:28:15PM +0200, Alexander Lobakin wrote:
> Unfortunately, it's not always possible to allocate
> max(num_rxqs, nr_cpu_ids) even on hi-end NICs.
> To mitigate this, add simple locking helpers to libeth_xdp.
> As long as XDPSQs are not shared, the whole functionality is gated
> behind a static lock. Otherwise, each bulk flush locks the queue for
> the time of cleaning and filling the descriptors.
> As long as this particular queue is not used by more than 1 CPU,
> the impact is minimal (runtime check for boolean twice per 16+
> descriptors).
>
> Suggested-by: Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx> # static key
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>

Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx>