Re: [PATCH 1/3] dt-bindings: clock: Add Qualcomm SC8180X Camera clock controller

[Satya Priya Kakitapalli]

On 4/22/2025 5:11 PM, Bryan O'Donoghue wrote:
> On 22/04/2025 06:42, Satya Priya Kakitapalli wrote:
> > Add device tree bindings for the camera clock controller on
> > Qualcomm SC8180X platform.
> >
> > Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@xxxxxxxxxxx>
> > ---
> >   .../bindings/clock/qcom,sc8180x-camcc.yaml         |  65 ++++++++
> >   include/dt-bindings/clock/qcom,sc8180x-camcc.h     | 181 
> > +++++++++++++++++++++
> >   2 files changed, 246 insertions(+)
> >
> > diff --git 
> > a/Documentation/devicetree/bindings/clock/qcom,sc8180x-camcc.yaml 
> > b/Documentation/devicetree/bindings/clock/qcom,sc8180x-camcc.yaml
> > new file mode 100644
> > index 
> > 0000000000000000000000000000000000000000..b17f40ee53a3002b2942869d60773dbecd764134
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/qcom,sc8180x-camcc.yaml
> > @@ -0,0 +1,65 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/qcom,sc8180x-camcc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm Camera Clock & Reset Controller on SC8180X
> > +
> > +maintainers:
> > +  - Satya Priya Kakitapalli <quic_skakitap@xxxxxxxxxxx>
> > +
> > +description: |
>
> You can drop the "|"

okay.


> > +  Qualcomm camera clock control module provides the clocks, resets and
> > +  power domains on SC8180X.
> > +
> > +  See also: include/dt-bindings/clock/qcom,sc8180x-camcc.h
> > +
> > +properties:
> > +  compatible:
> > +    const: qcom,sc8180x-camcc
> > +
> > +  clocks:
> > +    items:
> > +      - description: Board XO source
> > +      - description: Sleep clock source
>
> Missing clock-names

Since we are using DT based indexing method, clock names are not required.


> A suspicious lack of clock depends here. No AHB clock ?> +
> > +  power-domains:
> > +    maxItems: 1
> > +    description:
> > +      A phandle and PM domain specifier for the MMCX power domain.
> > +
> > +  required-opps:
> > +    maxItems: 1
> > +    description:
> > +      A phandle to an OPP node describing required MMCX performance 
> > point.
> > +
> > +allOf:
> > +  - $ref: qcom,gcc.yaml#
>
> A suspicious lack of clock depends here. No AHB clock ? No dependency 
> on gcc ?
>
> You call out the gcc above.
>
> Could you please recheck your list of clock dependencies.

The dependent GCC clocks are marked always on from gcc probe, hence did 
not mention the dependency here.


> ---
> bod