Re: [RFC PATCH v2 13/34] x86/xen/msr: Remove the error pointer argument from set_reg()

From: Jürgen Groß
Date: Thu Apr 24 2025 - 06:12:08 EST


On 22.04.25 10:21, Xin Li (Intel) wrote:
set_reg() is used to write the following MSRs on Xen:

MSR_FS_BASE
MSR_KERNEL_GS_BASE
MSR_GS_BASE

But none of these MSRs are written using any MSR write safe API.
Therefore there is no need to pass an error pointer argument to
set_reg() for returning an error code to be used in MSR safe APIs.

set_seg(), please (further up, too).


Remove the error pointer argument.

Signed-off-by: Xin Li (Intel) <xin@xxxxxxxxx>

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature