RE: [PATCH -next] mmc: sdhci-esdhc-imx: fix defined but not used warnings

[Bough Chen]

> -----Original Message-----
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Sent: 2025年4月24日 11:46
> To: linux-kernel@xxxxxxxxxxxxxxx
> Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>; Luke Wang
> <ziniu.wang_1@xxxxxxx>; Ulf Hansson <ulf.hansson@xxxxxxxxxx>;
> linux-mmc@xxxxxxxxxxxxxxx; Bough Chen <haibo.chen@xxxxxxx>;
> imx@xxxxxxxxxxxxxxx; dl-S32 <S32@xxxxxxx>
> Subject: [PATCH -next] mmc: sdhci-esdhc-imx: fix defined but not used warnings
> 
> [Some people who received this message don't often get email from
> rdunlap@xxxxxxxxxxxxx. Learn why this is important at
> https://aka.ms/LearnAboutSenderIdentification ]
> 
> Fix warnings when CONFIG_PM=y and CONFIG_PM_SLEEP is not set by
> surrounding the 2 functions with #ifdef CONFIG_PM_SLEEP.
> 
> drivers/mmc/host/sdhci-esdhc-imx.c:1659:13: warning:
> 'sdhc_esdhc_tuning_restore' defined but not used [-Wunused-function]
>  1659 | static void sdhc_esdhc_tuning_restore(struct sdhci_host *host)
> drivers/mmc/host/sdhci-esdhc-imx.c:1637:13: warning:
> 'sdhc_esdhc_tuning_save' defined but not used [-Wunused-function]
>  1637 | static void sdhc_esdhc_tuning_save(struct sdhci_host *host)

Reviewed-by: Haibo Chen <haibo.chen@xxxxxxx>

Regards
Haibo Chen
> 
> Fixes: 3d1eea493894 ("mmc: sdhci-esdhc-imx: Save tuning value when card
> stays powered in suspend")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Luke Wang <ziniu.wang_1@xxxxxxx>
> Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Cc: linux-mmc@xxxxxxxxxxxxxxx
> Cc: Haibo Chen <haibo.chen@xxxxxxx>
> Cc: imx@xxxxxxxxxxxxxxx
> Cc: s32@xxxxxxx
> ---
>  drivers/mmc/host/sdhci-esdhc-imx.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- linux-next-20250423.orig/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ linux-next-20250423/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -1634,6 +1634,7 @@ static void sdhci_esdhc_imx_hwinit(struc
>         }
>  }
> 
> +#ifdef CONFIG_PM_SLEEP
>  static void sdhc_esdhc_tuning_save(struct sdhci_host *host)  {
>         struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -1688,6
> +1689,7 @@ static void sdhc_esdhc_tuning_restore(st
>                        host->ioaddr + ESDHC_TUNE_CTRL_STATUS);
>         }
>  }
> +#endif
> 
>  static void esdhc_cqe_enable(struct mmc_host *mmc)  {