Re: [PATCH next] phy: tegra: xusb: remove a stray unlock

[Jon Hunter]

On 23/04/2025 14:08, Dan Carpenter wrote:
> We used to take a lock in tegra186_utmi_bias_pad_power_on() but now we
> have moved the lock into the caller.  Unfortunately, when we moved the
> lock this unlock was left behind and it results in a double unlock.
> Delete it now.
>
> Fixes: b47158fb4295 ("phy: tegra: xusb: Use a bitmask for UTMI pad power state tracking")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
>   drivers/phy/tegra/xusb-tegra186.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
> index cc7b8a6a999f..23a23f2d64e5 100644
> --- a/drivers/phy/tegra/xusb-tegra186.c
> +++ b/drivers/phy/tegra/xusb-tegra186.c
> @@ -656,8 +656,6 @@ static void tegra186_utmi_bias_pad_power_on(struct tegra_xusb_padctl *padctl)
>   	} else {
>   		clk_disable_unprepare(priv->usb2_trk_clk);
>   	}
> -
> -	mutex_unlock(&padctl->lock);
>   }
>   
>   static void tegra186_utmi_bias_pad_power_off(struct tegra_xusb_padctl *padctl)


Reviewed-by: Jon Hunter <jonathanh@xxxxxxxxxx>

Thanks for catching and fixing this!

Jon

--
nvpublic