Re: [PATCH] libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drive

From: Damien Le Moal
Date: Thu Apr 24 2025 - 01:44:15 EST


On 4/24/25 02:21, Mikko Juhani Korhonen wrote:
> Make WDC WD20EFAX-68FB5N0 hard drive work again
> after regression in 6.9.0 when LPM was enabled,
> so disable it for this model.
>
> Signed-off-by: Mikko Korhonen <mjkorhon@xxxxxxxxx>
>
> diff -u linux-6.14.3/drivers/ata/libata-core.c
> linux-6.14.3-mk/drivers/ata/libata-core.c
> --- linux-6.14.3/drivers/ata/libata-core.c 2025-04-20
> 11:23:22.000000000 +0300
> +++ linux-6.14.3-mk/drivers/ata/libata-core.c 2025-04-22
> 16:53:52.341934384 +0300
> @@ -4238,6 +4238,11 @@
> { "WDC WD2500JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
> { "WDC WD3000JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
> { "WDC WD3200JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
> +
> + /*
> + * This specific WD SATA-3 model has problems with LPM.
> + */
> + { "WDC WD20EFAX-68FB5N0", NULL, ATA_QUIRK_NOLPM },
>
> /*
> * This sata dom device goes on a walkabout when the ATA_LOG_DIRECTORY

This looks OK but the patch seems broken (missing separator after sign-off so
this does not apply.
Please use "git format-patch" to generate proper patches.
Also please change the patch title to:

ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives

--
Damien Le Moal
Western Digital Research