Re: [PATCH 5/8] staging: sm750fb: rename sii164_set_power's param

[Greg Kroah-Hartman]

On Thu, Apr 17, 2025 at 08:02:53PM +0100, Ruben Wauters wrote:
> Renames sii164_set_power's param from powerUp to power
> 
> This fixes checkpatch.pl's camel case check
> 
> Signed-off-by: Ruben Wauters <rubenru09@xxxxxxx>
> ---
>  drivers/staging/sm750fb/ddk750_sii164.c | 6 +++---
>  drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
> index 9f660a9be5d6..e2da110fab81 100644
> --- a/drivers/staging/sm750fb/ddk750_sii164.c
> +++ b/drivers/staging/sm750fb/ddk750_sii164.c
> @@ -262,14 +262,14 @@ char *sii164_get_chip_string(void)
>   *      This function sets the power configuration of the DVI Controller Chip.
>   *
>   *  Input:
> - *      powerUp - Flag to set the power down or up
> + *      power - Flag to set the power down or up

But now we don't know if it's "up" or "down", right?  Why not pick
"power_up"?

And shouldn't this be a boolean, and not an unsigned char?

thanks,

greg k-h