Re: [PATCH v2 0/2] rename var for slice refill event and add helper

[Changwoo Min]

Hi Honglei,

Thanks for the contribution. The change looks good to me.

Acked-by: Changwoo Min <changwoo@xxxxxxxxxx>

On 4/18/25 12:26, Honglei Wang wrote:
> SCX_EV_ENQ_SLICE_DFL gives the impression that the event only occurs
> when the tasks were enqueued, which seems not accurate. So rename the
> variable to SCX_EV_REFILL_SLICE_DFL.
>
> The slice refilling with default slice always come with event
> statistics together, add a helper routine to make it cleaner.
>
> Changes in v2:
> Refine the comments base on Andrea's suggestion.
>
> Honglei Wang (2):
>    sched_ext: change the variable name for slice refill event
>    sched_ext: add helper for refill task with default slice
>
>   kernel/sched/ext.c             | 36 +++++++++++++++++-----------------
>   tools/sched_ext/scx_qmap.bpf.c |  4 ++--
>   2 files changed, 20 insertions(+), 20 deletions(-)