Re: [PATCH v2 2/2] dt-bindings: mmc: sdhci-am654: Add ti,suppress-v1p8-ena

[Judith Mendez]

Hi Francesco,

On 4/17/25 2:19 PM, Francesco Dolcini wrote:
> Hello Judith,
> thanks for the patch.
>
> On Thu, Apr 17, 2025 at 01:26:52PM -0500, Judith Mendez wrote:
> > This patch documents ti,suppress-v1p8-ena which is a flag
> > used to suppress V1P8_SIGNAL_ENA in sdhci_am654 driver. This
> > quirk is necessary to fix fail init issues across various
> > types of SD cards tested on Sitara K3 SoCs.
>
> bindings are supposed to describe the hardware, not the driver.
>
> You should rephrase the commit message and the description of the property with
> this in mind.
>
> In addition, I think that the dt-bindings is supposed to be before the driver
> patch in the series.

Right, will fix for v3 along with adding fixes tags.

~ Judith