Re: [PATCH 1/1] mm/rmap: add CONFIG_MM_ID guard for folio_test_large_maybe_mapped_shared()
From: Lance Yang
Date: Thu Apr 17 2025 - 10:31:33 EST
On Thu, Apr 17, 2025 at 9:26 PM David Hildenbrand <david@xxxxxxxxxx> wrote:
>
> On 17.04.25 15:24, Lance Yang wrote:
> > Hi David,
> >
> > Thanks for taking the time to review!
> >
> > On Thu, Apr 17, 2025 at 8:56 PM David Hildenbrand <david@xxxxxxxxxx> wrote:
> >>
> >> On 17.04.25 14:49, Lance Yang wrote:
> >>> Add a compile-time check to make sure folio_test_large_maybe_mapped_shared()
> >>> is only used with CONFIG_MM_ID enabled, as it directly accesses the _mm_ids
> >>> field that only works under CONFIG_MM_ID.
> >>>
> >>> Suggested-by: David Hildenbrand <david@xxxxxxxxxx>
> >>> Signed-off-by: Mingzhe Yang <mingzhe.yang@xxxxxx>
> >>
> >> ^ should that be here?
> >
> > Yep, that's my email too ;p
>
> Best to stick to only one here -- same individual :)
Got it. I'll keep that in mind next time ;)
Thanks,
Lance
>
> --
> Cheers,
>
> David / dhildenb
>