Re: [PATCH v4 03/14] cxl/pci: Add comments to cxl_hdm_decode_init()

From: Robert Richter
Date: Thu Apr 17 2025 - 09:11:31 EST


On 14.03.25 11:33:37, Jonathan Cameron wrote:
> On Thu, 6 Mar 2025 17:44:37 +0100
> Robert Richter <rrichter@xxxxxxx> wrote:
>
> > There are various configuration cases of HDM decoder registers causing
> > different code paths. Add comments to cxl_hdm_decode_init() to better
> > explain them.
> >
> > Signed-off-by: Robert Richter <rrichter@xxxxxxx>
> > Tested-by: Gregory Price <gourry@xxxxxxxxxx>
> Trivial comment inline.
> Otherwise I think this is fine.
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

> > + /*
> > + * The HDM Decoder Capability exists but is globally disabled.
>
> Single line comment syntax appropriate here.
>
> > + */

Changed that.

Thanks for review.

-Robert