Re: [PATCH v2] staging: gpib: include: fixes multiline comments style
From: Greg KH
Date: Thu Apr 17 2025 - 05:25:46 EST
On Wed, Apr 16, 2025 at 02:04:09PM -0700, Paul Retourné wrote:
> Fixes the style of multiline comments to comply with the linux kernel
> coding style.
>
> Signed-off-by: Paul Retourné <paul.retourne@xxxxxxxxx>
I've applied this (took some manual intervention on my side), but:
> @@ -37,11 +38,13 @@ struct gpib_board_config {
> unsigned int ibirq;
> /* dma channel to use for non-pnp cards (set by core, driver should make local copy) */
> unsigned int ibdma;
> - /* pci bus of card, useful for distinguishing multiple identical pci cards
> + /*
> + * pci bus of card, useful for distinguishing multiple identical pci cards
> * (negative means don't care)
> */
> int pci_bus;
For these, and the other definitions in this file, can you move the
comments to use the proper kerneldoc format for the structure, so that
the tools can properly document the structures in here? Having comments
above the variables really is not the best way to do this.
thanks,
greg k-h