Re: [PATCH] staging: bcm2835-camera: Initialise dev in v4l2_dev

From: Stefan Wahren
Date: Thu Apr 17 2025 - 05:20:32 EST


Am 14.04.25 um 19:41 schrieb Dave Stevenson:
Commit 42a2f6664e18 ("staging: vc04_services: Move global g_state to
vchiq_state") changed mmal_init to pass dev->v4l2_dev.dev to
vchiq_mmal_init, however nothing iniitialised dev->v4l2_dev, so we got
a NULL pointer dereference.

Set dev->v4l2_dev.dev during bcm2835_mmal_probe. The device pointer
could be passed into v4l2_device_register to set it, however that also
has other effects that would need additional changes.

Fixes: 42a2f6664e18 ("staging: vc04_services: Move global g_state to vchiq_state")
Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
---

Reviewed-by: Stefan Wahren <wahrenst@xxxxxxx>