Re: [PATCH v3] cpufreq: fix compile-test defaults
From: Viresh Kumar
Date: Thu Apr 17 2025 - 04:07:11 EST
On 17-04-25, 09:56, Krzysztof Kozlowski wrote:
> On 17/04/2025 09:28, Johan Hovold wrote:
> > Commit 3f66425a4fc8 ("cpufreq: Enable COMPILE_TEST on Arm drivers")
> > enabled compile testing of most Arm CPUFreq drivers but left the
> > existing default values unchanged so that many drivers are enabled by
> > default whenever COMPILE_TEST is selected.
> >
> > This specifically results in the S3C64XX CPUFreq driver being enabled
> > and initialised during boot of non-S3C64XX platforms with the following
> > error logged:
> >
> > cpufreq: Unable to obtain ARMCLK: -2
> >
> > Commit d4f610a9bafd ("cpufreq: Do not enable by default during compile
> > testing") recently fixed most of the default values, but two entries
> > were missed and two could use a more specific default condition.
> >
> > Fix the default values for drivers that can be compile tested and that
> > should be enabled by default when not compile testing.
> >
> > Fixes: 3f66425a4fc8 ("cpufreq: Enable COMPILE_TEST on Arm drivers")
>
> I would not consider original code a bug, but a feature, however I am
> fine with other choice as well, so to close discussion from my side:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Applied. Thanks.
--
viresh