Re: [PATCH 2/2] arm64: dts: qcom: qcs8300: Add cpufreq scaling node

[Imran Shaik]

On 4/14/2025 4:36 PM, Konrad Dybcio wrote:
> On 3/13/25 7:03 AM, Imran Shaik wrote:
>> Add cpufreq-hw node to support cpufreq scaling on QCS8300.
>>
>> Signed-off-by: Imran Shaik <quic_imrashai@xxxxxxxxxxx>
>> ---
> 
> [...]
> 
>> +		cpufreq_hw: cpufreq@18591000 {
>> +			compatible = "qcom,qcs8300-cpufreq-epss", "qcom,cpufreq-epss";
>> +			reg = <0x0 0x18591000 0x0 0x1000>,
>> +			      <0x0 0x18594000 0x0 0x1000>,
>> +			      <0x0 0x18593000 0x0 0x1000>;
>> +			reg-names = "freq-domain0", "freq-domain1", "freq-domain2";
> 
> Please turn these into vertical lists> +
>> +			interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
>> +			interrupt-names = "dcvsh-irq-0", "dcvsh-irq-1", "dcvsh-irq-2";
> 
> Since these labels don't match the hardware anyway, please sort them by address
> 

Sure, I will take care of the above comments and post another series.

Thanks,
Imran
> Konrad
> 
>> +
>> +			clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_GPLL0>;
>> +			clock-names = "xo", "alternate";
>> +
>> +			#freq-domain-cells = <1>;
>> +		};
>> +
>>  		remoteproc_gpdsp: remoteproc@20c00000 {
>>  			compatible = "qcom,qcs8300-gpdsp-pas", "qcom,sa8775p-gpdsp0-pas";
>>  			reg = <0x0 0x20c00000 0x0 0x10000>;
>>