Re: [PATCH v2 5/5] watchdog: qcom: add support to read the restart reason from IMEM

From: Kathiravan Thirumoorthy
Date: Thu Apr 17 2025 - 02:19:46 EST



On 4/16/2025 8:21 PM, Konrad Dybcio wrote:
.max_tick_count = 0xFFFFFU,
};
+static int qcom_wdt_get_restart_reason(struct qcom_wdt *wdt,
double space> + const struct qcom_wdt_match_data *data)

Please align this


Ack.


+{
+ struct regmap *imem;
+ unsigned int val;
+ int ret;
+
+ imem = syscon_regmap_lookup_by_compatible(data->compatible);
I still think nvmem could be better here, as it allows to plug in
more magic values


Sure, I will be on vacation next week. I shall check on how to use nvmem here once I'm back.



Konrad