Re: [PATCH net-next v4 00/14] yt6801: Add Motorcomm yt6801 PCIe driver

[Frank Sae]

On 2025/4/14 04:33, Andrew Lunn wrote:
> On Fri, Apr 11, 2025 at 05:50:55PM +0800, Frank Sae wrote:
>>
>>
>> On 2025/4/8 18:30, Russell King (Oracle) wrote:
>>> On Tue, Apr 08, 2025 at 05:28:21PM +0800, Frank Sae wrote:
>>>> This series includes adding Motorcomm YT6801 Gigabit ethernet driver
>>>>  and adding yt6801 ethernet driver entry in MAINTAINERS file.
>>>> YT6801 integrates a YT8531S phy.
>>>
>>> What is different between this and the Designware GMAC4 core supported
>>> by drivers/net/ethernet/stmicro/stmmac/ ?
>>>
>>
>> We support more features: NS, RSS, wpi, wol pattern and aspm control.
> 
> Details please as to why these preventing the stmmac driver from being
> used? Our default opinion will be that you will extend that stmmac
> driver. In order to change that, you need to give us deep technical
> arguments why it cannot be done.
> 

After internal discussion, we have decided to temporarily suspend upstream.
Thanks again!

>>> Looking at the register layout, it looks very similar. The layout of the
>>> MAC control register looks similar. The RX queue and PMT registers are
>>> at the same relative offset. The MDIO registers as well.
>>>
>>> Can you re-use the stmmac driver?
>>>
>>
>> I can not re-use the stmmac driver, because pcie and ephy can not work well on
>> the stmmac driver.
> 
> Please could you explain that in detail. What exactly does not work?
> What is stmmac_pci.c about if not PCI?
> 
> 	Andrew