Re: [PATCH] scatterlist: inline sg_next()

[Andrew Morton]

On Wed, 16 Apr 2025 10:06:13 -0600 Caleb Sander Mateos <csander@xxxxxxxxxxxxxxx> wrote:

> sg_next() is a short function called frequently in I/O paths. Define it
> in the header file so it can be inlined into its callers.

Does this actually make anything faster?

net/ceph/messenger_v2.c has four calls to sg_next().  x86_64 defconfig:

x1:/usr/src/25> size net/ceph/messenger_v2.o
   text	   data	    bss	    dec	    hex	filename
  31486	   2212	      0	  33698	   83a2	net/ceph/messenger_v2.o

after:

  31742	   2212	      0	  33954	   84a2	net/ceph/messenger_v2.o

More text means more cache misses.  Possibly the patch slows things down??