Re: [PATCH 07/10] x86/fpu: Refactor xfeature bitmask update code for sigframe XSAVE

[Chang S. Bae]

On 4/16/2025 1:05 AM, Ingo Molnar wrote:
> * Chang S. Bae <chang.seok.bae@xxxxxxxxx> wrote:
>
> > +static inline int set_xfeature_in_sigframe(struct xregs_state __user *xbuf, u64 mask)
> > +{
> > +	u64 xfeatures;
> > +	int err;
> > +
> > +	/* Read the xfeatures value already saved in the user buffer */
> > +	err  = __get_user(xfeatures, &xbuf->header.xfeatures);
> > +	xfeatures |= mask;
> > +	err |= __put_user(xfeatures, &xbuf->header.xfeatures);
> > +	return err;
> > +}
>
> For future reference, please put an extra newline before 'return'
> statements, so that the code looks more 'balanced':
>
> > +{
> > +	u64 xfeatures;
> > +	int err;
> > +
> > +	/* Read the xfeatures value already saved in the user buffer */
> > +	err  = __get_user(xfeatures, &xbuf->header.xfeatures);
> > +	xfeatures |= mask;
> > +	err |= __put_user(xfeatures, &xbuf->header.xfeatures);
> > +
> > +	return err;
> > +}

I see. Thanks for the note.

> I've done that for this patch, so no need to resend it.

Thanks!
Chang