Re: [PATCH v12 13/26] x86/resctrl: Implement resctrl_arch_config_cntr() to assign a counter with ABMC

[Moger, Babu]

Hi Reinette,

On 4/15/25 11:38, Reinette Chatre wrote:
> Hi Babu,
> 
> On 4/14/25 1:51 PM, Moger, Babu wrote:
>> Hi Reinette,
>>
>> On 4/11/25 16:02, Reinette Chatre wrote:
>>> Hi Babu,
>>>
>>> On 4/3/25 5:18 PM, Babu Moger wrote:
> 
>>>> @@ -394,6 +394,21 @@ void resctrl_arch_mon_event_config_set(void *config_info);
>>>>  u32 resctrl_arch_mon_event_config_get(struct rdt_mon_domain *d,
>>>>  				      enum resctrl_event_id eventid);
>>>>  
>>>> +/**
>>>> + * resctrl_arch_config_cntr() - Configure the counter on the domain
>>>> + * @r:			resource that the counter should be read from.
>>>> + * @d:			domain that the counter should be read from.
>>>> + * @evtid:		event type to assign
>>>> + * @rmid:		rmid of the counter to read.
>>>> + * @closid:		closid that matches the rmid.
>>>> + * @cntr_id:		Counter ID to configure
>>>> + * @evt_cfg:		event configuration
>>>
>>> "event configuration" is simply an expansion of member name and does not help to
>>> understand what the value represents.
>>
>> How about?
>>
>> "MBM Event configuration value representing reads, writes etc.."
> 
> This is more helpful (note Event -> event). When data structures are decided it
> will also be helpful to include reference of where this data is maintained and
> how it is formatted.

Sure.
-- 
Thanks
Babu Moger