Re: [PATCH v2 15/15] drm: renesas: rz-du: mipi_dsi: Add support for RZ/V2H(P) SoC

[Geert Uytterhoeven]

Hi Prabhakar, Fabrizio,

On Tue, 8 Apr 2025 at 22:09, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Add DSI support for Renesas RZ/V2H(P) SoC.
>
> Co-developed-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c
> +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c
> @@ -70,6 +80,18 @@ struct rzg2l_mipi_dsi {
>         unsigned int num_data_lanes;
>         unsigned int lanes;
>         unsigned long mode_flags;
> +
> +       struct rzv2h_dsi_mode_calc mode_calc;
> +       struct rzv2h_plldsi_parameters dsi_parameters;
> +};
> +
> +static const struct rzv2h_plldsi_div_limits rzv2h_plldsi_div_limits = {
> +       .m = { .min = 64, .max = 1023 },

.max = 533?

> +       .p = { .min = 1, .max = 4 },
> +       .s = { .min = 0, .max = 5 },

.max = 6?

> +       .k = { .min = -32768, .max = 32767 },
> +       .csdiv = { .min = 1, .max = 1 },
> +       .fvco = { .min = 1050 * MEGA, .max = 2100 * MEGA }
>  };

Summarized: why do these values differ from the ones in the declaration
macro RZV2H_CPG_PLL_DSI_LIMITS(), i.e. why can't you use the latter?

>
>  static inline struct rzg2l_mipi_dsi *

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds