Re: [PATCH] watchdog: diag288_wdt: Implement module autoload

From: Heiko Carstens
Date: Wed Apr 16 2025 - 03:22:45 EST


On Tue, Apr 15, 2025 at 09:51:35AM -0700, Guenter Roeck wrote:
> On 4/15/25 09:24, Heiko Carstens wrote:
> > On Thu, Apr 10, 2025 at 05:10:50AM -0700, Guenter Roeck wrote:
> > > On 4/10/25 02:50, Heiko Carstens wrote:
> > > > The s390 specific diag288_wdt watchdog driver makes use of the virtual
> > > > watchdog timer, which is available in most machine configurations.
> > > > If executing the diagnose instruction with subcode 0x288 results in an
> > > > exception the watchdog timer is not available, otherwise it is available.
> > > > ---
> > > > arch/s390/boot/startup.c | 17 ++++++++++
> > > > arch/s390/include/asm/cpufeature.h | 1 +
> > > > arch/s390/include/asm/diag288.h | 41 +++++++++++++++++++++++
> > > > arch/s390/include/asm/machine.h | 1 +
> > > > arch/s390/kernel/cpufeature.c | 5 +++
> > > > drivers/watchdog/diag288_wdt.c | 53 ++----------------------------
> > > > 6 files changed, 68 insertions(+), 50 deletions(-)
> > > > create mode 100644 arch/s390/include/asm/diag288.h
> >
> > Guenter, Wim, I assume this can/should go upstream via the s390 tree?
>
> It touches s390 core code, and you did not suggest otherwise when submitting
> the patch, so that was my assumption.

Sure, just wanted to check that everybody is fine with this.
Will apply this later to the s390 tree.

Thanks!