Re: [PATCH] ASoC: Intel: sof_sdw: Add NULL check in asoc_sdw_rt_dmic_rtd_init()

[Markus Elfring]

> mic_name returned by devm_kasprintf() could be NULL.
> Add a check for it.

Was this patch also supported by the source code analysis tool “KNighter”?


…
> +++ b/sound/soc/sdw_utils/soc_sdw_rt_dmic.c
> @@ -29,6 +29,8 @@ int asoc_sdw_rt_dmic_rtd_init(struct snd_soc_pcm_runtime *rtd, struct snd_soc_da
>  		mic_name = devm_kasprintf(card->dev, GFP_KERNEL, "rt715-sdca");
>  	else
>  		mic_name = devm_kasprintf(card->dev, GFP_KERNEL, "%s", component->name_prefix);
…

How do you think about to use the function “devm_kstrdup” in one if branch instead
(by another update step)?
https://elixir.bootlin.com/linux/v6.14-rc6/source/drivers/base/devres.c#L958-L965

Regards,
Markus