Re: [PATCH v14 3/3] rtc: sophgo: add rtc support for Sophgo CV1800 SoC

[Chen Wang]

Hi, Alexander Sverdlin,

I just find there is an exiting "REAL TIME CLOCK (RTC) SUBSYSTEM" 
section in MAINTAINERS, seems we should not pick the rtc file in "SOPHGO 
DEVICETREES and DRIVERS".

Chen

On 2025/3/19 8:31, Chen Wang wrote:
> Hi, Inochi,
>
> I see Alexander add "drivers/rtc/rtc-cv1800.c" in "SOPHGO DEVICETREES 
> and DRIVERS" of MAINTAINERS, would you like to take this?
>
> Regards,
>
> Chen
>
> On 2025/3/16 6:49, Alexander Sverdlin wrote:
> > From: Jingbao Qiu <qiujingbao.dlmu@xxxxxxxxx>
> >
> > Implement the RTC driver for CV1800, which able to provide time alarm.
> >
> > Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@xxxxxxxxx>
> > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx>
> > ---
> > Changelog:
> > v14:
> > - platform device name "cv1800-rtc" -> "cv1800b-rtc"
> > v13:
> > - Change in the Kconfig dependency caused by the move of the previous
> >    patch from MFD into SOC
> > v12:
> > - added MAINTAINERS entry
> > - depends on cv1800-rtcsys MFD driver
> > - use syscon for regmap
> > - get named clock from parent MFD
> > - corresponding platform device is expected to be instantiated by MFD 
> > stub
> > Changes since v10:
> > - only start RTC on set_time;
> > Changes since v9:
> > - further simplified bitmask macros;
> > - unconditional RTC start (rtc_enable_sec_counter()), otherwise
> > didn't start on SG2000;
> > - dropped ANA_CALIB modification (has been forgotten in v8 with
> > the drop of SW calibration to switch to HW calibration);
> > - successfully tested on SG2000;
> >
> >
> >   MAINTAINERS              |   1 +
> >   drivers/rtc/Kconfig      |  12 +++
> >   drivers/rtc/Makefile     |   1 +
> >   drivers/rtc/rtc-cv1800.c | 218 +++++++++++++++++++++++++++++++++++++++
> >   4 files changed, 232 insertions(+)
> >   create mode 100644 drivers/rtc/rtc-cv1800.c
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index ac15e448fffb..be8fee50a49c 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -22354,6 +22354,7 @@ L:    sophgo@xxxxxxxxxxxxxxx
> >   W:    https://github.com/sophgo/linux/wiki
> >   T:    git https://github.com/sophgo/linux.git
> >   S:    Maintained
> > +F:    drivers/rtc/rtc-cv1800.c
> >   N:    sophgo
> >   K:    sophgo
>
> [......]