Re: [PATCH] ftrace: Fix type of ftrace_graph_ent_entry.depth

From: Ilya Leoshkevich
Date: Sat Apr 12 2025 - 17:01:39 EST


On 2025-04-12 18:07, Steven Rostedt wrote:
On Fri, 11 Apr 2025 19:21:41 +0200
Ilya Leoshkevich <iii@xxxxxxxxxxxxx> wrote:


- F_printk("--> %ps (%lu)", (void *)__entry->func, __entry->depth)
+ F_printk("--> %ps (%d)", (void *)__entry->func, __entry->depth)

depth should never be negative. Why did you use "%d" and not "%u" ?

-- Steve

I used int, because it's int in ftrace_graph_ent and all other events.
If you think it's a good idea, I can change them all to unsigned int in a follow-up patch.