Re: [PATCH v3] media: add virtio-media driver

From: Markus Elfring
Date: Sat Apr 12 2025 - 10:28:37 EST



> +++ b/drivers/media/virtio/virtio_media_driver.c
> @@ -0,0 +1,959 @@

> +static struct virtio_media_session *
> +virtio_media_session_alloc(struct virtio_media *vv, u32 id,
> + bool nonblocking_dequeue)
> +{

> + init_waitqueue_head(&session->dqbuf_wait);
> +
> + mutex_lock(&vv->sessions_lock);
> + list_add_tail(&session->list, &vv->sessions);
> + mutex_unlock(&vv->sessions_lock);
> +
> + return session;


Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&vv->sessions_lock);”?
https://elixir.bootlin.com/linux/v6.14-rc6/source/include/linux/mutex.h#L201

Regards,
Markus