Re: [PATCH kernfs 1/3] kernfs: switch global kernfs_idr_lock to per-fs lock

[Greg KH]

On Sat, Apr 12, 2025 at 02:31:07AM +0800, alexjlzheng@xxxxxxxxx wrote:
> From: Jinliang Zheng <alexjlzheng@xxxxxxxxxxx>
> 
> The kernfs implementation has big lock granularity(kernfs_idr_lock) so
> every kernfs-based(e.g., sysfs, cgroup) fs are able to compete the lock.
> 
> This patch switches the global kernfs_idr_lock to per-fs lock, which
> put the spinlock into kernfs_root.
> 
> Signed-off-by: Jinliang Zheng <alexjlzheng@xxxxxxxxxxx>
> ---
>  fs/kernfs/dir.c             | 14 +++++++-------
>  fs/kernfs/kernfs-internal.h |  1 +
>  2 files changed, 8 insertions(+), 7 deletions(-)

What kind of testing / benchmark did you do for this series that shows
that this works, AND that this actually is measureable?  What workload
are you doing that causes these changes to be needed?

thanks,

greg k-h