Re: [PATCH V2] PCI: dwc: tegra194: Broaden architecture dependency
From: Niklas Cassel
Date: Fri Apr 11 2025 - 01:43:29 EST
On Fri, Apr 11, 2025 at 01:15:52AM +0530, Vidya Sagar wrote:
> Replace ARCH_TEGRA_194_SOC dependency with a more generic ARCH_TEGRA
> check, allowing the PCIe controller to be built on Tegra platforms
> beyond Tegra194. Additionally, ensure compatibility by requiring
> ARM64 or COMPILE_TEST.
>
> Link: https://patchwork.kernel.org/project/linux-pci/patch/20250128044244.2766334-1-vidyas@xxxxxxxxxx/
> Signed-off-by: Vidya Sagar <vidyas@xxxxxxxxxx>
> ---
> v2:
> * Addressed review comments from Niklas Cassel and Manivannan Sadhasivam
>
> drivers/pci/controller/dwc/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index d9f0386396ed..815b6e0d6a0c 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -226,7 +226,7 @@ config PCIE_TEGRA194
>
> config PCIE_TEGRA194_HOST
> tristate "NVIDIA Tegra194 (and later) PCIe controller (host mode)"
> - depends on ARCH_TEGRA_194_SOC || COMPILE_TEST
> + depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST)
> depends on PCI_MSI
> select PCIE_DW_HOST
> select PHY_TEGRA194_P2U
> @@ -241,7 +241,7 @@ config PCIE_TEGRA194_HOST
>
> config PCIE_TEGRA194_EP
> tristate "NVIDIA Tegra194 (and later) PCIe controller (endpoint mode)"
> - depends on ARCH_TEGRA_194_SOC || COMPILE_TEST
> + depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST)
> depends on PCI_ENDPOINT
> select PCIE_DW_EP
> select PHY_TEGRA194_P2U
> --
> 2.25.1
>
Reviewed-by: Niklas Cassel <cassel@xxxxxxxxxx>