Re: [PATCH] drm/msm/dpu: Fix error pointers in dpu_plane_virtual_atomic_check

[Abhinav Kumar]

On 3/13/2025 6:10 PM, Chenyuan Yang wrote:
> The function dpu_plane_virtual_atomic_check was dereferencing pointers
> returned by drm_atomic_get_plane_state without checking for errors. This
> could lead to undefined behavior if the function returns an error pointer.
>
> This commit adds checks using IS_ERR to ensure that plane_state is
> valid before dereferencing them.
>
> Similar to commit da29abe71e16
> ("drm/amd/display: Fix error pointers in amdgpu_dm_crtc_mem_type_changed").
>
> Fixes: 774bcfb73176 ("drm/msm/dpu: add support for virtual planes")
> Signed-off-by: Chenyuan Yang <chenyuan0y@xxxxxxxxx>
> ---
>   drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 3 +++
>   1 file changed, 3 insertions(+)

Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>