Re: [PATCH v2 2/3] drm/panel: simple: Tianma TM070JDHG34-00: add delays

[Luca Ceresoli]

Hi Dmitry,

Thanks for reviewing.

On Tue, 8 Apr 2025 15:52:19 +0300
Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx> wrote:

> On Mon, Apr 07, 2025 at 06:34:00PM +0200, Luca Ceresoli wrote:
> > Add power on/off delays for the Tianma TM070JDHG34-00.
> > 
> > Signed-off-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>
> > ---
> >  drivers/gpu/drm/panel/panel-simple.c | 6 ++++++
> >  1 file changed, 6 insertions(+)  
> 
> Fixes: bf6daaa281f7 ("drm/panel: simple: Add Tianma TM070JDHG34-00 panel support")
> 
> > 
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index df718c4a86cb7dc0cd126e807d33306e5a21d8a0..3496ed3e62056938ccc0ed2389ea46eed8d17ea2 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -4452,6 +4452,12 @@ static const struct panel_desc tianma_tm070jdhg34_00 = {
> >  		.width = 150, /* 149.76 */
> >  		.height = 94, /* 93.60 */
> >  	},
> > +	.delay = {
> > +		.prepare = 18,		/* Tr + Tp1 */  
> 
> I think this should be 15, Tr is handled by the regulator, so no need to
> handled it in the panel driver.

Hm, I think you are right.

I'm applying both changes but I'll wait a few days before sending v3,
in case of further feedback.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com