Re: [PATCH v6 2/2] arm64: dts: qcom: ipq5424: Enable PCIe PHYs and controllers

[Dmitry Baryshkov]

On 08/04/2025 15:49, Manikanta Mylavarapu wrote:
> On 4/3/2025 3:02 PM, Dmitry Baryshkov wrote:
> > On Thu, 3 Apr 2025 at 08:08, Manikanta Mylavarapu
> > <quic_mmanikan@xxxxxxxxxxx> wrote:
> > > On 4/2/2025 7:50 PM, Dmitry Baryshkov wrote:
> > > > On Wed, Apr 02, 2025 at 03:57:23PM +0530, Manikanta Mylavarapu wrote:
> > > > > Enable the PCIe controller and PHY nodes corresponding to RDP466.
> > > > >
> > > > > Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@xxxxxxxxxxx>
> > > > > ---
> > > > > Changes in V6:
> > > > >       - No change.
> > > > >
> > > > >   arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts | 41 ++++++++++++++++++++-
> > > > >   1 file changed, 40 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> > > > > index 0fd0ebe0251d..1f89530cb035 100644
> > > > > --- a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> > > > > +++ b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> > > > > @@ -82,6 +82,32 @@ &dwc_1 {
> > > > >       dr_mode = "host";
> > > > >   };
> > > > >
> > > > > +&pcie2 {
> > > > > +    pinctrl-0 = <&pcie2_default_state>;
> > > > > +    pinctrl-names = "default";
> > > > > +
> > > > > +    perst-gpios = <&tlmm 31 GPIO_ACTIVE_LOW>;
> > > >
> > > >
> > > > No wake-gpios? Please document it in the commit message.
> > >
> > > Hi Dmitry,
> > >
> > > Thank you for reviewing the patch.
> > >
> > > The wake GPIO is dropped because the PCIe on the IPQ5424 doesn't support low power mode.
> > > I will document this information in the commit message and post the next version.
> >
> > If the GPIO is routed on the PCB I think it should still be described in the DT.
>
> Hi Dmitry,
>
> 	I have confirmed with the hardware team that the wake GPIO is not routed on the PCB.

Sad. Please mention it in the commit message.

> Thanks & Regards,
> Manikanta.


--
With best wishes
Dmitry